fix: move content to the middle and redirect to podman desktop on page load event

[dgolovin]

Fix #40. Cannot avoid opening page right now, but redirect on window load event works.

Open podman desktop on window load

Screen.Recording.2024-03-04.at.8.11.40.PM.mov

Open podman desktop using button on the page

Screen.Recording.2024-03-04.at.8.14.27.PM.mov

[vrothberg]

LGTM, tested successfully, thanks!

Waiting for @benoitf's code review before merging.

[dgolovin]

I did not focus on how the page looks, should be follow up issue. I just moved it to middle page to avoid it to be covered when browser asks about using podman desktop to open the link.

[jeffmaury]

Works for me but having handled the positive response in the local http server would allow better workflow

[benoitf]

I think this URL is not handled/managed by Podman Desktop and I'm not sure it'll be this URL being used.

Either we use a shorter URL that is accepted/handled property
or we need to add inside Podman Desktop a way to handle /preferences/authentication-providers but in that case I think it might be missing a prefix

[dgolovin]

I see now, basically I can have podman-desktop:/// and it would give the same result.

[dgolovin]

we need to add inside Podman Desktop a way to handle /preferences/authentication-providers but in that case I think it might be missing a prefix

Do you mean a prefix similar to podman-desktop://extension/ used in extension installation?

Would something like podman-desktop://goto/preferences/authentication-providers work? So we can translate it to router.goto('/preferences/authentication-providers')` call on podman desktop side.

[benoitf]

as side comments, I was wondering why the copyright of the css file is Microsoft

/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/

and about the page, I think it would be better if the page would be self-contained/minimized/production-ready b/c here we're fetching from internet the patternfly library for example

(follow-up issues)

I would just make the podman-desktop:// redirect link shorter as the link being used is not implemented and many not be implemented like that in the future

[dgolovin]

@benoitf can I push it for now, then open all follow ups?

[benoitf]

@dgolovin please use podman-desktop:// for now and you can merge with that

[benoitf]

@dgolovin I think this can be discussed in follow-up

IMHO I think we need to ask to redirect to an extension page/command then it's the responsibility of the extension to do whatever the extension want. (There are some navigation API available for the extension)

But for now I think it's OK to just asking to bring back the main window of Podman Desktop on top by just asking podman-desktop://

[vrothberg]

Testing now with the latest main from Podman Desktop (i.e., commit 287c15d429c1):
When clicking on sign in, the tab will open in the browser but the focus is still on Podman Desktop not on the tab.

Can others reproduce?

[benoitf]

@vrothberg looks like I've got the expected behavior on my side (focus on Chrome then Podman Desktop)

Screen.Recording.2024-03-06.at.13.46.24.mov

I used the same sha

$ git log -1 | head -1                                                                                                                                                                                                                                   
commit 287c15d429c1dd104c3451012ccce9e37d50da45

[dgolovin]

@vrothberg same for me, it works as expected, browser gets focus.