fix: add redhat registry logo

[dgolovin]

Fix #38.

[dgolovin]

There seems to be an issue with spacing between icon and registry name for this kind of entries.

[benoitf]

IMHO we should include the png image as a resource

like https://github.com/containers/podman-desktop/blob/main/extensions/registries/src/extension.ts#L22

and https://github.com/containers/podman-desktop/blob/main/extensions/registries/src/extension.ts#L70-72

so you don't need to read the file, it's included in the .js file
also if the file is not found, it raises compilation error while in your case it'll be deferred to the runtime

[dgolovin]

I was looking for that, but missed it. I'll update the PR.

[vrothberg]

There seems to be an issue with spacing between icon and registry name for this kind of entries.

Is that something to fix in Podman Desktop or the extension?

Is there a way we can change the name to "Red Hat Container Registry"?

[jeffmaury]

Shouldn't we have a more friendly name ?

[benoitf]

I've added the name change in the GitHub UI suggested change

[vrothberg]

I've added the name change in the GitHub UI suggested change

Looks great, thank you!

The only very minor thing that strikes my eyes is the user name. It looks cryptic as it's machine-generated. Not sure how we could beautify that.

[benoitf]

• do you have a way to provide metadata to make it shorter as well ? (like -pd vs -podman-desktop) (probably something we can tune on our side)

• can we have emails rather than digits on registry.redhat.io side ? like username "[email protected]"

• we could enrich Podman Desktop API to include a username alias. So it could display "[email protected]" but if you try to edit it'll display you real digit-podman-desktop value but at least it would render more nicely. One issue is that for now the data are stored in auth.json so there won't be issue in Podman if we add extra fields in auth.json ?

like

{
        "auths": {
                "quay.io": {
                        "alias": "[email protected]",
                        "auth": "encoded-value"
                }
        }
}

[vrothberg]

I am unable to answer the questions but am sure that @dgolovin knows. I like the idea of displaying the email address used in SSO.

[benoitf]

@vrothberg do you know if podman will ignore extra fields that we may store in containers/auth.conf file ?

[vrothberg]

@vrothberg do you know if podman will ignore extra fields that we may store in containers/auth.conf file ?

It's JSON, so it very likely ignores unknown fields. But it's dangerous territory as it may break at any time in the future if we exploit the auth.conf for another purpose.

[benoitf]

I'm also fine to have the png import in a follow up PR

[dgolovin]

@benoitf There is no way to control user name, I call API with request to create 'podman-desktop' service account and it returns json with username/password. It looks like user name is generated as ${organizationID}|${requested-service-account-name}.

[dgolovin]

BTW icon and name for the registry does not survive podman desktop restart podman-desktop/podman-desktop#6218

[dgolovin]

Created follow up issue #68