improve machine error when running on Linux #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
benoitf
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
LGTM
I would expect tests but it seems there is currently only one unit test in the repository
@dgolovin probably need to add more tests so contributors can plug to existing unit tests, extend them. Here it might be difficult to setup the full logic when you're just contributing
On Linux, Podman Desktop can talk to the Podman socket of the host and to the ones of the Linux VM. As outlinted in redhat-developer#42, talking to socket of the host's Podman is currently not supported by the extension. While logging into the container registry is perfectly fine, running subscriptio-manager is not; it requires root privileges to install and run it. So instead of a silent error, throw a user-visible error indicating that it's currently not supported on a Linux host. Fixes: redhat-developer#42 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
hackathon-subscription
branch
from
1c6fa85 to
12692fd
Compare
|
Can we get this in? |
|
@vrothberg I think you can merge, 1 week without any other remark and one approval :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, Podman Desktop can talk to the Podman socket of the host and to the ones of the Linux VM. As outlinted in #42, talking to socket of the host's Podman is currently not supported by the extension. While logging into the container registry is perfectly fine, running subscriptio-manager is not; it requires root privileges to install and run it. So instead of a silent error, throw a user-visible error indicating that it's currently not supported on a Linux host.
Fixes: #42