chore(ci): add PR check e2e linux workflow #155
Conversation
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
|
@dgolovin We got a nice pipeline now. One question is that if we want e2e test job to be run after unit tests (which is totally right) and at the same time as build job, or even after build (we also make sure to run e2e tests once all other jobs are in a good shape). WDYT? |
I would run them after unit tests |
| yarn build | ||
| podman build -t local_sso_image ./ | ||
| CONTAINER_ID=$(podman create localhost/local_sso_image --entrypoint "") | ||
| podman export $CONTAINER_ID > /tmp/local_sso_image.tar |
There was a problem hiding this comment.
Use podman save as it's more logical
There was a problem hiding this comment.
But it save command does not create an archive with a file system structure (extension content) that I could use, right? that is why I need to create a container which will open the way to get to a content of an extension.
I think we have discussed that in bootc PR: https://github.com/containers/podman-desktop-extension-bootc/pull/224/files/a74d54c8731175665099c4039aafca44f6fef9f8#r1560816381
But If there is a way to use podman save I am all for, I just failed to find a way with using image directly.
There was a problem hiding this comment.
There should be a simpler way to do it ie use the cdix file but it looks overpopulated so giving a +1
| yarn build | ||
| podman build -t local_sso_image ./ | ||
| CONTAINER_ID=$(podman create localhost/local_sso_image --entrypoint "") | ||
| podman export $CONTAINER_ID > /tmp/local_sso_image.tar |
There was a problem hiding this comment.
There should be a simpler way to do it ie use the cdix file but it looks overpopulated so giving a +1
@jeffmaury It would be awesome to use ie. a file produced from a build. But I do not have access to it, unless it is available on the registry. Also, we should make sure to grab or use anything that actually produces the extension, which is in this case a containerfile, so it does not leave much space for simpler solution, unfortunately. but I would be very glad to find something more straightforward. Thanks! |
Fixed #93.
Add PR check job that build extension locally and use it when running e2e tests. Encouraging shift-left workflow.