fix: Allow requesting flat scalar values in workspace/configuration #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
reviewed
Jan 15, 2025
src/main/java/com/redhat/devtools/lsp4ij/client/LanguageClientImpl.java
Outdated
Show resolved
Hide resolved
Enaium
force-pushed
the
main
branch
3 times, most recently
from
5d64070 to
618a09c
Compare
Enaium
commented
Jan 16, 2025
Comment on lines
-51
to
-54
| public void testGetSettingsIdentityOnEmptySections() { | ||
| String[] requestedPath = new String[0]; | ||
| assertFindSettings(testJson, requestedPath, testJson); | ||
| } |
There was a problem hiding this comment.
string array is never empty
Enaium
commented
Jan 16, 2025
| @@ -248,14 +248,13 @@ protected Object findSettings(@Nullable String section) { | |||
| if (section == null) { | |||
| return config; | |||
| } | |||
| String[] sections = section.split("[.]"); | |||
There was a problem hiding this comment.
string array is never empty
angelozerr
reviewed
Jan 16, 2025
src/test/java/com/redhat/devtools/lsp4ij/client/SettingsHelperTest.java
Outdated
Show resolved
Hide resolved
|
Thanks so much, it looks great! Last thing, could you add new tests with your language server and write 3 tests:
Having those 3 tests will be nice to have a concrete sample. |
|
Thanks @Enaium ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #746