fix: Added support for non-standard member token type reported by the TypeScript language server for static methods
#692
Conversation
…g syntax-highlighted properly. After digging in, it's because they're being reported as non-standard token type "member" instead of "method". This addresses that omission and also creates a more formal way to add non-standard token types.
SCWells72
changed the title
static methodsmember token type reported by the TypeScript language server for static methods
|
@SCWells72 I understand that the result is very nice, but I would like to really avoid hard code custom token for each language server. My idea for user defined language server is to have
|
|
I see that you rebase your PR but as I have tried to explain, I would like to have a more generic support to do that like vscode provides. Hope you will understand. |
Oh, I'm just rebasing all open branches to keep things fresh for when I return to them. I'm not actively working on these right now. I'll change this to a draft PR to prevent any further confusion. |
|
Closing this as the simple approach here has been rejected and the more extensive proposed alternative is probably out-of-scope for me anytime soon. |
|
I am sorry @SCWells72 but I hope you understand my point of view. My fear is that each ls will want to add their own custom tokens |
No, I understand. However, if you truly want to be strict about that stance, then the current special handling for |
This is probably best demonstrated visually. Here's the syntax highlighting without this fix:
and here it is with this fix:
Note the lack of highlighting for the declaration and usage of
staticmethoddemoin the first image and the proper highlighting of both in the second image.