fix : Modification to replace the usage of deprecated method DumbService.runReadActionInSmartMode(Computable) #1421
Conversation
…ted method DumbService.runReadActionInSmartMode(Computable)
|
dessina-devasia
changed the title
| @@ -222,7 +220,8 @@ public Location findPropertyLocation(VirtualFile file, String sourceType, String | |||
| } | |||
|
|
|||
| public Location findPropertyLocation(Module module, String sourceType, String sourceField, String sourceMethod, IPsiUtils utils) { | |||
| return DumbService.getInstance(module.getProject()).runReadActionInSmartMode(() -> { | |||
There was a problem hiding this comment.
Like you have removed ReadAction in ProjectLabelManager, should we need this wrap with ReadAction ?
There was a problem hiding this comment.
@angelozerr I've already added ReadAction block here. So, no need to wrap this in ReadAction
There was a problem hiding this comment.
That's very strange because this findPropertyLocation should be called also in a non blocking read action in the QuarkusLanguageClient.
Do you see trouble if you remove this ReadAction?
There was a problem hiding this comment.
@angelozerr Let me test the same without ReadAction and will update you.
There was a problem hiding this comment.
@angelozerr Removed the ReadAction.nonBlocking() as findPropertyLocation() is already executed in a NonBlocking ReadAction.
…eady executed in a NonBlocking ReadAction
DumbService.runReadActionInSmartMode(Computable)Fixes #1420