fix: allow to refresh all contexts (#809) #811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #809
The refresh that's available in the context menu has no effect if no context is selected.
intellij-kubernetes/src/main/kotlin/com/redhat/devtools/intellij/kubernetes/actions/RefreshAction.kt
Line 26 in 719d72c
The refresh action should not return without doing anything. It should call
ResourceModel.invalidate()
instead, which then should refresh the whole tree.intellij-kubernetes/src/main/kotlin/com/redhat/devtools/intellij/kubernetes/model/ResourceModel.kt
Lines 174 to 176 in 719d72c
I dont know how to test this other than by debugging with breakpoints and looking at the code. Updates on the cluster are watched and acted upon. Same for the config files. I am not aware of a use case where a refresh would change the state of the resource tree :(