Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making gitops-must-gather structure compliant with the default one. #23

Merged

Conversation

gmeghnag
Copy link
Contributor

@gmeghnag gmeghnag commented May 21, 2024

What type of PR is this?

/kind code-refactoring

What does this PR do / why we need it:
It makes gitops-must-gather compliant with the structure of the standard one to be able to parse it using omc, i.e.:

# omc use must-gather.local.7868235141633891323 
# omc get argocd,application -A 
NAMESPACE          NAME                      AGE
openshift-gitops   argocd/openshift-gitops   4h
pippo              argocd/example            2h

NAMESPACE          NAME                               SYNC STATUS   HEALTH STATUS   REVISION
openshift-gitops   application/app-spring-petclinic   Synced        Healthy         c294d23a3bb98062f96ad9e19426632f433adf40
# omc get argocd example -n pippo -o json | jq
{
  "controller": {
    "processors": {},
    "sharding": {}
  },
  "grafana": {
    "enabled": false,
    "ingress": {
      "enabled": false
    },
    "route": {
      "enabled": false
    }
  },
  "ha": {
    "enabled": false
  },
  "initialSSHKnownHosts": {},
  "monitoring": {
    "enabled": false
  },
  "notifications": {
    "enabled": false
  },
  "prometheus": {
    "enabled": false,
    "ingress": {
      "enabled": false
    },
    "route": {
      "enabled": false
    }
  },
  "rbac": {},
  "redis": {},
  "repo": {},
  "server": {
    "autoscale": {
      "enabled": false
    },
    "grpc": {
      "ingress": {
        "enabled": false
      }
    },
    "ingress": {
      "enabled": false
    },
    "route": {
      "enabled": true
    },
    "service": {
      "type": ""
    }
  },
  "tls": {
    "ca": {}
  }
}
# omc get po -n openshift-gitops
NAME                                                          READY   STATUS    RESTARTS   AGE
cluster-b6c4d4dbf-b4sz2                                       1/1     Running   0          4h
kam-8657fd448d-f4hc8                                          1/1     Running   0          4h
openshift-gitops-application-controller-0                     1/1     Running   0          4h
openshift-gitops-applicationset-controller-69fc864c68-5bwcx   1/1     Running   0          4h
openshift-gitops-dex-server-df476794-49kmb                    1/1     Running   0          4h
openshift-gitops-redis-6b4b4dc49b-ptr6r                       1/1     Running   0          4h
openshift-gitops-repo-server-5c85f7479-tfm65                  1/1     Running   0          4h
openshift-gitops-server-77df6b9f69-twjqn                      1/1     Running   0          4h

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
It "fixes" #20.

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:
You can test it by running:

oc adm must-gather --image=quay.io/gmeghnag/gitops-must-gather:latest

Making gitops-must-gather structure compliant with the default one.

Signed-off-by: gmeghnag <[email protected]>
@openshift-ci openshift-ci bot requested review from iam-veeramalla and wtam2018 May 21, 2024 16:41
@gmeghnag
Copy link
Contributor Author

@iam-veeramalla @wtam2018 could you please review this PR?

@reginapizza reginapizza merged commit 73f119f into redhat-developer:main May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants