Replace Go image in the Dockerfile #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chetan-rns
force-pushed
the
update-go-image
branch
from
f8db95f to
9a743dd
Compare
|
#40 should pass once we merge this PR |
anandf
reviewed
Sep 27, 2024
Dockerfile
Outdated
| WORKDIR /root/ | ||
| # Use distroless as minimal base image to package the manager binary | ||
| # Refer to https://github.com/GoogleContainerTools/distroless for more details | ||
| FROM gcr.io/distroless/static:nonroot |
There was a problem hiding this comment.
For Go binaries built with CGO_ENABLED=0 option , we could use FROM scratch. I assume there is no other other dependency required for this binary (like bash etc).
Signed-off-by: Chetan Banavikalmutt <[email protected]>
chetan-rns
force-pushed
the
update-go-image
branch
from
9a743dd to
e331d26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it:
The base image used in the Dockerfile
openshift/origin-release:golang-1.21doesn't exist. Replace this image with the standard Golang image from DockerHub.Ref: https://github.com/redhat-developer/gitops-operator/blob/master/Dockerfile
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer: