Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icons for editors #1045

Merged
merged 1 commit into from
Feb 8, 2024
Merged

feat: add icons for editors #1045

merged 1 commit into from
Feb 8, 2024

Conversation

svor
Copy link
Contributor

@svor svor commented Feb 8, 2024

What does this PR do?

The plugin-registry-generator was published with recent changes contributed by eclipse-che/che-plugin-registry#1885

Now we can add icons for editors generated as a part of plugin registry image.

  • The icons are available by the link: PLUGIN_REGISTRY_URL/v3/images/
  • index.json that contains information about each editor, provides an information about the related icon

Tested on the cluster with custom plugin-registry image quay.io/vsvydenk/pluginregistry-rhel8:next:
screenshot-devspaces apps rosa bbcgz-o7zzh-orw uy30 p3 openshiftapps com-2024 02 08-17_02_59

screenshot-devspaces apps rosa bbcgz-o7zzh-orw uy30 p3 openshiftapps com-2024 02 08-17_12_07

What issues does this PR fix or reference?

eclipse-che/che#22766

Signed-off-by: Valeriy Svydenko <[email protected]>
@svor svor self-assigned this Feb 8, 2024
@svor svor requested review from ibuziuk and SDawley as code owners February 8, 2024 11:25
@svor svor requested a review from akurinnoy February 8, 2024 15:16
@svor svor merged commit e2aa9d0 into devspaces-3-rhel-8 Feb 8, 2024
5 checks passed
@svor svor deleted the sv-editors-icons branch February 8, 2024 17:22
@devstudio-release
Copy link
Contributor

Build 3.13 :: pluginregistry_3.x/292: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.13 :: pluginregistry_3.x/292: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6204 triggered

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.13 :: update-digests_3.x/5813: UNSTABLE

No new images detected: nothing to do!

svor added a commit that referenced this pull request Feb 9, 2024
Signed-off-by: Valeriy Svydenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants