-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use https endpoints for the che-code editors #1022
Conversation
Signed-off-by: Ilya Buziuk <[email protected]>
@svor could you please review? |
@nickboldt @SDawley does PR check support PRs from forks, or the branch should be created from origin? |
if a secret is needed to complete a test, then you must create your PR from the origin as GH secrets are not shared to collaborator's forks.
-- https://github.com/redhat-developer/devspaces/actions/runs/6785657331/job/18444462580?pr=1022 In this case, the problem is that you can't log into quay without the login secret, so yes, that test will never pass against your fork. Please resubmit using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
35d8a1e
into
redhat-developer:devspaces-3-rhel-8
Build 3.11 :: pluginregistry_3.x/268: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5200: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3621: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.x/5084: pluginregistry : 3.x :: Build 56824466 : quay.io/devspaces/pluginregistry-rhel8:3.11-4 |
Build 3.11 :: update-digests_3.x/4836: Console, Changes, Git Data |
Build 3.11 :: pluginregistry_3.x/268: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5200 triggered |
Build 3.11 :: operator-bundle_3.x/2263: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5203: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3622: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5203: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5085 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.11 :: operator-bundle_3.x/2263: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5203 triggered |
Build 3.11 :: copyIIBsToQuay/2109: Console, Changes, Git Data |
Build 3.11 :: dsc_3.x/1530: Console, Changes, Git Data |
Build 3.11 :: update-digests_3.x/4836: Detected new images: rebuild operator-bundle |
Build 3.11 :: dsc_3.x/1530: 3.11.0-CI |
Signed-off-by: Ilya Buziuk <[email protected]>
Signed-off-by: Ilya Buziuk <[email protected]>
What does this PR do?
fix: use https endpoints for the che-code editors
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-4869
upstream PR - eclipse-che/che-plugin-registry#1810
Release Notes
Docs PR (if applicable)