Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use https endpoints for the che-code editors #1022

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Nov 7, 2023

What does this PR do?

fix: use https endpoints for the che-code editors

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4869

upstream PR - eclipse-che/che-plugin-registry#1810

Release Notes

Docs PR (if applicable)

@ibuziuk ibuziuk requested a review from svor November 7, 2023 14:09
@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 7, 2023

@svor could you please review?

@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 7, 2023

@nickboldt @SDawley does PR check support PRs from forks, or the branch should be created from origin?

@nickboldt
Copy link
Member

nickboldt commented Nov 7, 2023

if a secret is needed to complete a test, then you must create your PR from the origin as GH secrets are not shared to collaborator's forks.

Error: Input required and not supplied: username

-- https://github.com/redhat-developer/devspaces/actions/runs/6785657331/job/18444462580?pr=1022

In this case, the problem is that you can't log into quay without the login secret, so yes, that test will never pass against your fork. Please resubmit using redhat-developer instead of ibuziuk

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR check build should be successful if you create a PR using a branch from original repo
I've tested changes and it seems good:
screenshot-devspaces apps ci-ln-913m0tk-76ef8 origin-ci-int-aws dev rhcloud com-2023 11 08-12_52_44

@ibuziuk ibuziuk merged commit 35d8a1e into redhat-developer:devspaces-3-rhel-8 Nov 8, 2023
4 of 5 checks passed
@devstudio-release
Copy link
Contributor

Build 3.11 :: pluginregistry_3.x/268: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.11 :: pluginregistry_3.x/268: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5200 triggered

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.11 :: sync-to-downstream_3.x/5203: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5085 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link
Contributor

Build 3.11 :: operator-bundle_3.x/2263: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5203 triggered

@devstudio-release
Copy link
Contributor

Build 3.11 :: copyIIBsToQuay/2109: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

Build 3.11 :: dsc_3.x/1530: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

Build 3.11 :: update-digests_3.x/4836: SUCCESS

Detected new images: rebuild operator-bundle
* pluginregistry; /DS_CI/operator-bundle_3.x/2263 triggered

@devstudio-release
Copy link
Contributor

Build 3.11 :: dsc_3.x/1530: SUCCESS

3.11.0-CI

svor pushed a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants