Refactor output format framework to support tables and empty format #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated instructions for generating changelog
retention bytes command -1 flag updated desc.
Co-authored-by: Wojciech Trocki <[email protected]>
updated Retention
WIP: Issues #1429 and 1440
wtrocki
reviewed
Apr 25, 2022
| endif | ||
| app-services-go-linter -path ./pkg/core/localize/locales ./... | ||
| .PHONY: lint-lang | ||
| # lint-lang: ## Lint i18n files |
wtrocki
reviewed
Apr 25, 2022
| endif | ||
| app-services-go-linter -path ./pkg/core/localize/locales ./... | ||
| .PHONY: lint-lang | ||
| # lint-lang: ## Lint i18n files |
wtrocki
reviewed
Apr 25, 2022
| @@ -1,30 +1,4 @@ | |||
|
|
|||
| <a name="v0.39.0"></a> | |||
There was a problem hiding this comment.
Restore this changelog (generate it)
wtrocki
reviewed
Apr 25, 2022
| @@ -1,30 +1,4 @@ | |||
|
|
|||
| <a name="v0.39.0"></a> | |||
There was a problem hiding this comment.
Restore this changelog (generate it)
wtrocki
approved these changes
Apr 25, 2022
|
We need to resolve conflicts, remove some extra changes. Then myself and @rkpattnaik780 can verify and merge this change |
|
Looks bit counter-intuitive to see "none" in |
gowriswarupk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motiviation
Addressing issue #1429
Changes made:
Verification Steps:
./rhoas kafka topic create --name=kannan --output=none