Skip to content

Commit

Permalink
feat: new connector commands are now not hidden (#1726)
Browse files Browse the repository at this point in the history
  • Loading branch information
jackdelahunt authored Aug 22, 2022
1 parent 1d7cac9 commit d410aed
Show file tree
Hide file tree
Showing 11 changed files with 190 additions and 6 deletions.
4 changes: 4 additions & 0 deletions docs/commands/rhoas_connector.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

48 changes: 48 additions & 0 deletions docs/commands/rhoas_connector_build.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 42 additions & 0 deletions docs/commands/rhoas_connector_create.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 38 additions & 0 deletions docs/commands/rhoas_connector_describe.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

53 changes: 53 additions & 0 deletions docs/commands/rhoas_connector_update.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cmd/connector/build/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func NewBuildCommand(f *factory.Factory) *cobra.Command {
Short: f.Localizer.MustLocalize("connector.build.cmd.shortDescription"),
Long: f.Localizer.MustLocalize("connector.build.cmd.longDescription"),
Example: f.Localizer.MustLocalize("connector.build.cmd.example"),
Hidden: true,
Hidden: false,
Args: cobra.NoArgs,
RunE: func(cmd *cobra.Command, args []string) error {
validOutputFormats := flagutil.ValidOutputFormats
Expand Down
2 changes: 0 additions & 2 deletions pkg/cmd/connector/connector.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ func NewConnectorsCommand(f *factory.Factory) *cobra.Command {
stop.NewStopCommand(f),
connector_type.NewTypeCommand(f),
list.NewListCommand(f),

// Hidden for the users and docs at the moment
create.NewCreateCommand(f),
build.NewBuildCommand(f),
delete.NewDeleteCommand(f),
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/connector/create/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func NewCreateCommand(f *factory.Factory) *cobra.Command {
Short: f.Localizer.MustLocalize("connector.create.cmd.shortDescription"),
Long: f.Localizer.MustLocalize("connector.create.cmd.longDescription"),
Example: f.Localizer.MustLocalize("connector.create.cmd.example"),
Hidden: true,
Hidden: false,
Args: cobra.NoArgs,
RunE: func(cmd *cobra.Command, args []string) error {
validOutputFormats := flagutil.ValidOutputFormats
Expand Down
1 change: 1 addition & 0 deletions pkg/cmd/connector/delete/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func NewDeleteCommand(f *factory.Factory) *cobra.Command {
Short: f.Localizer.MustLocalize("connector.delete.cmd.shortDescription"),
Long: f.Localizer.MustLocalize("connector.delete.cmd.longDescription"),
Example: f.Localizer.MustLocalize("connector.delete.cmd.example"),
Hidden: false,
Args: cobra.NoArgs,
RunE: func(cmd *cobra.Command, args []string) error {
validOutputFormats := flagutil.ValidOutputFormats
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/connector/describe/describe.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func NewDescribeCommand(f *factory.Factory) *cobra.Command {
Long: f.Localizer.MustLocalize("connector.describe.cmd.longDescription"),
Example: f.Localizer.MustLocalize("connector.describe.cmd.example"),
Args: cobra.NoArgs,
Hidden: true,
Hidden: false,
RunE: func(cmd *cobra.Command, args []string) error {

validOutputFormats := flagutil.ValidOutputFormats
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/connector/update/update.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func NewUpdateCommand(f *factory.Factory) *cobra.Command {
Long: f.Localizer.MustLocalize("connector.update.cmd.longDescription"),
Example: f.Localizer.MustLocalize("connector.update.cmd.example"),
Args: cobra.NoArgs,
Hidden: true,
Hidden: false,
RunE: func(cmd *cobra.Command, args []string) error {
validOutputFormats := flagutil.ValidOutputFormats
if opts.outputFormat != "" && !flagutil.IsValidInput(opts.outputFormat, validOutputFormats...) {
Expand Down

0 comments on commit d410aed

Please sign in to comment.