feat(consumer-group): display state (#1568)

redhat-developer · May 17, 2022 · c9d0737 · c9d0737
1 parent 789102f
commit c9d0737
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/pkg/cmd/kafka/consumergroup/describe/describe.go b/pkg/cmd/kafka/consumergroup/describe/describe.go
@@ -189,7 +189,8 @@ func printConsumerGroupDetails(w io.Writer, consumerGroupData kafkainstanceclien
 	partitionsWithLagCount := metrics.GetLaggingPartitions()
 	unassignedPartitions := metrics.GetUnassignedPartitions()
 
-	fmt.Fprintln(w, color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.activeMembers")), activeMembersCount, "\t", color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.partitionsWithLag")), partitionsWithLagCount, "\t", color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.unassignedPartitions")), unassignedPartitions)
+	fmt.Fprintln(w, color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.activeMembers")), activeMembersCount, "\t", color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.partitionsWithLag")), partitionsWithLagCount, "\t")
+	fmt.Fprintln(w, color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.unassignedPartitions")), unassignedPartitions, color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.state")), consumerGroupData.GetState())
 	fmt.Fprintln(w, "")
 
 	rows := mapConsumerGroupDescribeToTableFormat(consumers)

diff --git a/pkg/cmd/kafka/consumergroup/list/list.go b/pkg/cmd/kafka/consumergroup/list/list.go
@@ -41,9 +41,10 @@ type options struct {
 }
 
 type consumerGroupRow struct {
-	ConsumerGroupID   string `json:"groupId,omitempty" header:"Consumer group ID"`
-	ActiveMembers     int32  `json:"active_members,omitempty" header:"Active members"`
-	PartitionsWithLag int32  `json:"lag,omitempty" header:"Partitions with lag"`
+	ConsumerGroupID   string                                 `json:"groupId,omitempty" header:"Consumer group ID"`
+	ActiveMembers     int32                                  `json:"active_members,omitempty" header:"Active members"`
+	PartitionsWithLag int32                                  `json:"lag,omitempty" header:"Partitions with lag"`
+	State             kafkainstanceclient.ConsumerGroupState `json:"state,omitempty" header:"State"`
 }
 
 // NewListConsumerGroupCommand creates a new command to list consumer groups
@@ -185,6 +186,7 @@ func mapConsumerGroupResultsToTableFormat(consumerGroups []kafkainstanceclient.C
 			ConsumerGroupID:   t.GetGroupId(),
 			ActiveMembers:     metrics.GetActiveConsumers(),
 			PartitionsWithLag: metrics.GetLaggingPartitions(),
+			State:             t.GetState(),
 		}
 		rows[i] = row
 	}

diff --git a/pkg/core/localize/locales/en/cmd/kafka.en.toml b/pkg/core/localize/locales/en/cmd/kafka.en.toml
@@ -190,6 +190,9 @@ one = 'ACTIVE MEMBERS:'
 [kafka.consumerGroup.describe.output.partitionsWithLag]
 one = 'PARTITIONS WITH LAG:'
 
+[kafka.consumerGroup.describe.output.state]
+one = 'STATE:'
+
 [kafka.consumerGroup.describe.output.unassignedPartitions]
 one = 'UNASSIGNED PARTITIONS:'