fix: address review comments

redhat-developer · Apr 26, 2022 · 0741aa2 · 0741aa2
1 parent e134e8b
commit 0741aa2
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 22 deletions.
diff --git a/docs/commands/rhoas_generate-config.md b/docs/commands/rhoas_generate-config.md
diff --git a/pkg/cmd/generate/templates.go b/pkg/cmd/generate/templates.go
@@ -22,14 +22,14 @@ var (
 `)
 
 	templateJSON = heredoc.Doc(`
-		{	
-            {{if .KafkaHost}}"kafkaHost":"{{.KafkaHost}}",
-            {{end}}{{if .RegistryURL}}"serviceRegistryUrl":"{{.RegistryURL}}",
-            "serviceRegistryCorePath":"` + registrycmdutil.REGISTRY_CORE_PATH + `",
-            "serviceRegistryCompatPath":"` + registrycmdutil.REGISTRY_COMPAT_PATH + `",
-            {{end}}"rhoasClientID":"{{.ClientID}}",
-            "rhoasClientSecret":"{{.ClientSecret}}",
-            "rhoasOauthTokenUrl":"{{.TokenURL}}"
+		{
+			{{if .KafkaHost}}"kafkaHost":"{{.KafkaHost}}",
+			{{end}}{{if .RegistryURL}}"serviceRegistryUrl":"{{.RegistryURL}}",
+			"serviceRegistryCorePath":"` + registrycmdutil.REGISTRY_CORE_PATH + `",
+			"serviceRegistryCompatPath":"` + registrycmdutil.REGISTRY_COMPAT_PATH + `",
+			{{end}}"rhoasClientID":"{{.ClientID}}",
+			"rhoasClientSecret":"{{.ClientSecret}}",
+			"rhoasOauthTokenUrl":"{{.TokenURL}}"
 		}
 	`)
 
@@ -52,18 +52,20 @@ var (
 		apiVersion: v1
 		kind: Secret
 		metadata:
-            name: {{.Name}}
+      name: {{.Name}}
 		type: Opaque
 		stringData:
-            {{if .KafkaHost}}## Kafka Configuration
-            KAFKA_HOST: {{.KafkaHost}}{{end}}
-            {{if .RegistryURL}}## Service Registry Configuration
-            SERVICE_REGISTRY_URL: {{.RegistryURL}}
-            SERVICE_REGISTRY_CORE_PATH: ` + registrycmdutil.REGISTRY_CORE_PATH + `
-            SERVICE_REGISTRY_COMPAT_PATH: ` + registrycmdutil.REGISTRY_COMPAT_PATH + `
-            {{end}}
-            ## Authentication Configuration
-            RHOAS_CLIENT_ID: {{.ClientID}}
-            RHOAS_CLIENT_SECRET: {{.ClientSecret}}
-            RHOAS_OAUTH_TOKEN_URL: {{.TokenURL}}`)
+		  {{if .KafkaHost}}## Kafka Configuration
+		  KAFKA_HOST: {{.KafkaHost}}
+		  {{end}}
+		  {{if .RegistryURL}}## Service Registry Configuration
+		  SERVICE_REGISTRY_URL: {{.RegistryURL}}
+		  SERVICE_REGISTRY_COMPAT_PATH: ` + registrycmdutil.REGISTRY_COMPAT_PATH + `
+		  SERVICE_REGISTRY_CORE_PATH: ` + registrycmdutil.REGISTRY_CORE_PATH + `
+		  {{end}}
+		  ## Authentication Configuration
+		  RHOAS_CLIENT_ID: {{.ClientID}}
+		  RHOAS_CLIENT_SECRET: {{.ClientSecret}}
+		  RHOAS_OAUTH_TOKEN_URL: {{.TokenURL}}
+	`)
 )
diff --git a/pkg/core/localize/locales/en/cmd/generate_config.en.toml b/pkg/core/localize/locales/en/cmd/generate_config.en.toml
@@ -15,7 +15,7 @@ one='Type of configuration file to be generated'
 
 [generate.common.flag.fileLocation.description]
 description = 'Description for --output-file flag'
-one = 'Sets a custom file location to save the credentials'
+one = 'Sets a custom file location to save the configurations'
 
 
 [generate.log.info.noSevices]