Skip to content

Commit

Permalink
Merge pull request #238 from lhind-tia-cop/fix#232
Browse files Browse the repository at this point in the history
fix(): fix datatype for CRD spec.BoundClaims
  • Loading branch information
raffaelespazzoli authored May 28, 2024
2 parents 92cd512 + 48a3646 commit 3f6154d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
3 changes: 2 additions & 1 deletion api/v1alpha1/jwtoidcauthenginerole_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"reflect"

vaultutils "github.com/redhat-cop/vault-config-operator/api/v1alpha1/utils"
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"sigs.k8s.io/controller-runtime/pkg/client"
)
Expand Down Expand Up @@ -105,7 +106,7 @@ type JWTOIDCRole struct {
// Keys support JSON pointer syntax for referencing claims
// +kubebuilder:validation:Optional
// +kubebuilder:default={}
BoundClaims map[string]string `json:"boundClaims,omitempty"`
BoundClaims *apiextensionsv1.JSON `json:"boundClaims,omitempty"`

// Configures the interpretation of the bound_claims values.
// If "string" (the default), the values will treated as string literals and must match exactly.
Expand Down
6 changes: 2 additions & 4 deletions api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,12 @@ spec:
type: array
x-kubernetes-list-type: set
boundClaims:
additionalProperties:
type: string
description: If set, a map of claims (keys) to match against respective
claim values (values) The expected value may be a single string
or a list of strings The interpretation of the bound claim values
is configured with bound_claims_type Keys support JSON pointer syntax
for referencing claims
type: object
x-kubernetes-preserve-unknown-fields: true
boundClaimsType:
default: string
description: Configures the interpretation of the bound_claims values.
Expand Down

0 comments on commit 3f6154d

Please sign in to comment.