-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignition to simplified installer blueprint #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me, just wondering about a few things (which might be due to my lack of experience with this project):
- shouldn't the new option be documented somewhere?
- I don't see any blueprint import file option?
Thanks for reviewing
|
Then approved! |
@ericzolf Azure pipelines are failing and blocking the merge, but I suppose that's not related to the changes introduced in this PR, am I right? |
This Pull Request looks stale. Feel free to reopen it if you think it's a mistake. |
@ericzolf @maxamillion can you please look at why the PR was not merged after approval? Do I need to change anything? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I had already done it but let me approve (again).
The short answer is that I don't know, I thought I had approved but perhaps I haven't... Also I don't know if you see but many checks were not successful, though I doubt due to your changes. |
This Pull Request needs all checks to run successfully. Could you fix it @luisarizmendi? 🙏 |
This Pull Request needs all checks to run successfully. Could you fix it @luisarizmendi? 🙏 |
Description
We need to be able to include ignition definition for simplified installer images