fix: concatenate lists without embedding into an outer layer of list #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharmison-redhat
requested review from
maxamillion,
thom-at-redhat,
de1987,
resoluteCoder and
matoval
as code owners
|
Looks like the test on idempotency here is flaky, will need a bit to dig into the test suite you've built to figure out why |
jharmison-redhat
force-pushed
the
fix/start_compose-idempotency
branch
4 times, most recently
from
5d172a0 to
8eb2f95
Compare
ensure that the mocked up Weldr API will actually return a duplicate blueprint name and version to the one requested to induce failure
jharmison-redhat
force-pushed
the
fix/start_compose-idempotency
branch
from
8eb2f95 to
4e594f2
Compare
|
Tests issues appear to be fixed, the test now actually checks whether the flag works or not. @maxamillion @matoval please review and merge ASAP, this is blocking documented functionality that we could really use right now :) I'm happy to fix any nits that come up quickly. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #307
Description
Concatenate lists using the
+operator without encapsulating with an outer layer of list, since the length of the sum of the lists is the most important characteristicType of change
What is it?
Checklist