Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo url #14

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Conversation

akira6592
Copy link
Contributor

@akira6592 akira6592 commented Dec 14, 2024

What does this PR do?

Now the repo url https://github.com/redhat-cop/controller_configuration is redirected to https://github.com/redhat-cop/infra.aap_configuration.

So I fixed the repo url of infra.controller_configuration to https://github.com/redhat-cop/infra.controller_configuration in docs.

How should this be tested?

Is there a relevant Issue open for this?

Other Relevant info, PRs, etc

@akira6592 akira6592 requested a review from a team as a code owner December 14, 2024 00:52
@akira6592 akira6592 changed the title Fix repo url galaxy Fix repo url Dec 14, 2024
galaxy.yml Outdated
repository: https://github.com/redhat-cop/controller_configuration/
issues: https://github.com/redhat-cop/controller_configuration//issues
repository: https://github.com/redhat-cop/infra.controller_configuration/
issues: https://github.com/redhat-cop/infra.controller_configuration//issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like a double slash at some point got put in here, while you are at it could you fix that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djdanielsson Thank you for reviewing. I fixed it.

@sean-m-sullivan
Copy link
Contributor

Needs updated links are broken, and other pieces need to be fixed

@akira6592
Copy link
Contributor Author

@sean-m-sullivan Do you think should I fix other links by this PR?

e.g.

[GPL-3.0](https://github.com/redhat-cop/controller_configuration#licensing)

Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit 59aa6f2 into redhat-cop:devel Dec 14, 2024
6 of 13 checks passed
@djdanielsson
Copy link
Contributor

Oops didn't see the comments until after I hit merge cuz I saw the change I had wanted was done

@akira6592
Copy link
Contributor Author

akira6592 commented Dec 15, 2024

If it needed, I will fix other links by an other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants