Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new platform installation method of AAP 2.5 on OpenShift #261

Merged
merged 27 commits into from
Jan 15, 2025

Conversation

derekwaters
Copy link
Contributor

What does this PR do?

This PR modifies the aap_ocp_install role to support the new platform installation method introduced to the AAP operator in AAP 2.5. It is backward

How should this be tested?

Requires an OpenShift cluster with appropriate credentials, then run:

      ansible.builtin.include_role:
        name: "infra.aap_utilities.aap_ocp_install"

with configuration as specified in the README and vars files defined in the role.

Once complete, installation can be validated by accessing AAP via the quick links toolbar menu option.

Is there a relevant Issue open for this?

#260
resolves #260

Other Relevant info, PRs, etc

None

Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is at least one change that needs to happen, I don't have OCP to test this so I will wait for someone who does to review and approve or not

galaxy.yml Outdated Show resolved Hide resolved
@djdanielsson djdanielsson requested a review from branic November 21, 2024 21:30
@branic
Copy link
Collaborator

branic commented Nov 21, 2024

I'm planning on reviewing and testing, I'll should be able to get to it in the next day or two.

Copy link
Collaborator

@branic branic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekwaters Thank you for your patience with me reviewing this PR.

I'd liek to request a couple of changes. I've been to get a working installation, but so far have not been successful. The Operator is installed and working and I've been able to get a platform manifest created and it started with a controller defined, but for several minutes after the playbook completes the web ui fails during login (I think because the controller instance is not ready yet). So I think there needs to be some other checks to ensure that the system is ready to be used before the playbook ends.

Also, it would be good to support installing into a different namespace than the operator is installed in.

I'm still getting my head around how the 2.5 install works and will provide more feedback.

One last request is to add an example playbook for installing the 2.5 version. Maybe relabel the existing example to be 2.4 and below and the new example as 2.5 and above.

@derekwaters
Copy link
Contributor Author

This PR has been updated to include:

  1. The ability to install the operator and the platform in separate namespaces (when cluster-scoped operator channel is used)
  2. Additional checks for controller / eda / hub API availability before proceeding with the playbook
  3. Updated README to include separate example playbooks for 2.4 and earlier, and 2.5 and later

@djdanielsson
Copy link
Contributor

@branic have you had time to test it?

Copy link
Collaborator

@branic branic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekwaters This PR is looking good. I like the changes you've made after the last review. I've got a few more comments and requests and I think this PR will be good to merge.

P.S. Sorry for not seeing this sooner and getting the review done.
P.P.S @djdanielsson thanks for the ping.

roles/aap_ocp_install/README.md Outdated Show resolved Hide resolved
roles/aap_ocp_install/README.md Outdated Show resolved Hide resolved
roles/aap_ocp_install/README.md Outdated Show resolved Hide resolved
roles/aap_ocp_install/README.md Outdated Show resolved Hide resolved
roles/aap_ocp_install/README.md Outdated Show resolved Hide resolved
roles/aap_ocp_install/tasks/install-platform.yml Outdated Show resolved Hide resolved
roles/aap_ocp_install/tasks/pre-validate.yml Outdated Show resolved Hide resolved
roles/aap_ocp_install/tasks/pre-validate.yml Outdated Show resolved Hide resolved
changelogs/fragments/add_eda_install_on_ocp.yaml Outdated Show resolved Hide resolved
roles/aap_ocp_install/tasks/pre-validate-platform.yml Outdated Show resolved Hide resolved
@derekwaters derekwaters requested a review from branic January 15, 2025 03:20
Copy link
Collaborator

@branic branic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekwaters Thanks for all your work on this. My testing has been successful.

I see one more minor change to the readme that is needed and then I will merge.

roles/aap_ocp_install/README.md Show resolved Hide resolved
Copy link
Collaborator

@branic branic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @derekwaters.

@branic branic dismissed djdanielsson’s stale review January 15, 2025 19:47

The requested changes have been made.

@branic branic removed the request for review from djdanielsson January 15, 2025 19:48
@branic branic merged commit 042585f into redhat-cop:devel Jan 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the infra.aap_utilities.aap_ocp_install module to support AAP 2.5
3 participants