Customize beakerd container #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fdaencarrh
commented
Apr 11, 2022
fdaencarrh
commented
- Wait for mysql to be ready
- Run the process alone instead of using systemd
- Populate the beaker database
* Wait for mysql to be ready * Run the process alone instead of using systemd * Populate the beaker database
p3ck
reviewed
Apr 12, 2022
| @@ -10,7 +10,7 @@ server.webpath = "/bkr/" | |||
| # The charset=utf8 option is required for proper Unicode support. | |||
| # The pool_recycle setting is required for MySQL, which will (by default) | |||
| # terminate idle client connections after 10 hours. | |||
| sqlalchemy.dburi = "mysql://beaker:beaker@dci-beaker-containers_db_1/beaker?charset=utf8" | |||
| sqlalchemy.dburi = "mysql://beaker:beaker@172.20.0.10/beaker?charset=utf8" | |||
There was a problem hiding this comment.
How do we know this is the address?
There was a problem hiding this comment.
This address came from the docker-compose file:
https://github.com/redhat-cip/dci-beaker-containers/blob/main/container-compose.yml#L21
I will try to use a variable instead.
There was a problem hiding this comment.
I created static addresses for each container for use in beaker config files.
miburke
reviewed
Apr 12, 2022
|
|
||
| # Poll until MySQL responds to our ping. | ||
| function wait_for_mysql() { | ||
| while ! mysqladmin -h 172.20.0.10 -u root -ppassword ping &>/dev/null; do |
There was a problem hiding this comment.
Should we limit the number of attempts to connect in case there is a problem with the DB? Maybe 2 minutes? It seems the DB is usually ready in about 30 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.