Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new requirements for PR to checklist #113

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add a new requirements for PR to checklist #113

wants to merge 4 commits into from

Conversation

yulisuliman
Copy link
Collaborator

@yulisuliman yulisuliman commented Apr 21, 2022 •
edited
Loading

  • Add a new requirements when PR conatin view chenge, need to upload a pictures of these changes.

fix #114
Dependant on #82

MatanP12 and others added 4 commits April 21, 2022 15:10
@MatanP12 @yulisuliman
Adding CheckList.md file
47fa25e 
Adding checklist to fill when commiting.
@MatanP12 @yulisuliman
Adding a section
10f4d7e 
Adding a section to avoid using Django default models name
@MatanP12 @yulisuliman
Change line 22
dee3038 
Change line 22 from:
`Above each test should have a comment that describes what the test is meant for.`
to
`Each test should have a comment above it to describe the test's purpose.`
@yulisuliman
Add Requirements for PR to checklist
dba8379
@yulisuliman yulisuliman self-assigned this May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yulisuliman yulisuliman

Labels
Status/Backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Checklist
2 participants
@yulisuliman @MatanP12