-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checklist #82
Open
MatanP12
wants to merge
1
commit into
redhat-beyond:main
Choose a base branch
from
MatanP12:add-checklist
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add checklist #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatanP12
added
documentation
Improvements or additions to documentation
ready for review
labels
Apr 10, 2022
MatanP12
requested review from
AlonShakaroff,
OmerCS8,
TomerNewmanPrograms and
yulisuliman
April 10, 2022 17:46
TomerNewmanPrograms
requested changes
Apr 10, 2022
OmerCS8
previously approved these changes
Apr 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice work!
Maybe change the label to 'backlog' as it is not at top priority to the demo 😉.
Is there an issue linked to this PR? |
Open
yulisuliman
previously approved these changes
Apr 12, 2022
abiton1
reviewed
Apr 18, 2022
yulisuliman
previously approved these changes
Apr 24, 2022
TomerNewmanPrograms
previously approved these changes
Apr 27, 2022
natifridman
requested changes
Apr 27, 2022
MatanP12
dismissed stale reviews from TomerNewmanPrograms and yulisuliman
via
April 28, 2022 15:23
1d82df6
yulisuliman
previously approved these changes
Apr 29, 2022
abiton1
previously approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
natifridman
previously approved these changes
May 25, 2022
Adding checklist to fill when commiting.
MatanP12
dismissed stale reviews from natifridman, abiton1, and yulisuliman
via
May 25, 2022 14:41
29ed17f
natifridman
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a checklist I built from previous PRs code reviews.
@AlonShakaroff @yulisuliman @TomerNewmanPrograms @OmerCS8 Please tell me if there are more common things I should add 🙂
fix #90