Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checklist #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

MatanP12
Copy link
Collaborator

@MatanP12 MatanP12 commented Apr 10, 2022

Hi,

This is a checklist I built from previous PRs code reviews.
@AlonShakaroff @yulisuliman @TomerNewmanPrograms @OmerCS8 Please tell me if there are more common things I should add 🙂

fix #90

@MatanP12 MatanP12 added documentation Improvements or additions to documentation ready for review labels Apr 10, 2022
OmerCS8
OmerCS8 previously approved these changes Apr 10, 2022
Copy link
Collaborator

@OmerCS8 OmerCS8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work!
Maybe change the label to 'backlog' as it is not at top priority to the demo 😉.

@abiton1
Copy link
Contributor

abiton1 commented Apr 12, 2022

Is there an issue linked to this PR?

@yulisuliman yulisuliman mentioned this pull request Apr 12, 2022
@yulisuliman
Copy link
Collaborator

Please add fix #90 to this PR
@MatanP12

@MatanP12
Copy link
Collaborator Author

Please add fix #90 to this PR @MatanP12

done 😄

yulisuliman
yulisuliman previously approved these changes Apr 12, 2022
docs/CheckList.md Outdated Show resolved Hide resolved
yulisuliman
yulisuliman previously approved these changes Apr 24, 2022
docs/CheckList.md Outdated Show resolved Hide resolved
yulisuliman
yulisuliman previously approved these changes Apr 29, 2022
abiton1
abiton1 previously approved these changes May 9, 2022
Copy link
Contributor

@abiton1 abiton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

natifridman
natifridman previously approved these changes May 25, 2022
Adding checklist to fill when commiting.
@MatanP12 MatanP12 dismissed stale reviews from natifridman, abiton1, and yulisuliman via 29ed17f May 25, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Status/Backlog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add checklist
6 participants