Update linker to provide new webviewAssets field #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niedzielski
approved these changes
Jun 13, 2024
| @@ -60,7 +60,7 @@ | |||
| "gzip": "3.5 KB" | |||
| }, | |||
| "dist/play-pen.js": { | |||
| "none": "37000 KB", | |||
| "none": "37200 KB", | |||
There was a problem hiding this comment.
wow. I wonder what changed to cost so much. I don't think we had any big bumps in the other repos. I was expecting this to go down since we had so many deletions from @devvit/protos for post guidance and it's kind of a bummer.
There was a problem hiding this comment.
Not sure! There's also a discrepancy between the compressed sizes on github actions vs local build. I had to bump the gzip'd size for play-pen.js although it passes locally.
src/bundler/linker.ts
Outdated
| @@ -1,21 +1,29 @@ | |||
| import type {LinkedBundle, SerializableServiceDefinition} from '@devvit/protos' | |||
| import type {AssetMap} from '@devvit/shared-types/Assets.js' | |||
|
|
|||
| type LinkerAssetMaps = { | |||
| // Standard assets from the /assets project path | |||
There was a problem hiding this comment.
💅 suggest JSDocs so the IDE reports these docs.
ObsidianSnoo
force-pushed
the
webview-asset-updates
branch
from
4b2c770 to
2014fbb
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
🧪 Testing Steps / Validation
✅ Checks