Move event declarations to the elements that emit them, remove unneed…

…ed async
reddit · May 24, 2024 · 4295cd1 · 4295cd1
1 parent 5e2faea
commit 4295cd1
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 3 deletions.
diff --git a/src/elements/play-assets-dialog.ts b/src/elements/play-assets-dialog.ts
@@ -24,6 +24,9 @@ import './play-assets/play-assets-local-archive.js'
 import './play-dialog/play-dialog.js'
 
 declare global {
+  interface HTMLElementEventMap {
+    'assets-filesystem-change': CustomEvent<AssetsFilesystemChange>
+  }
   interface HTMLElementTagNameMap {
     'play-assets-dialog': PlayAssetsDialog
   }

diff --git a/src/elements/play-assets/play-assets-local-archive.ts b/src/elements/play-assets/play-assets-local-archive.ts
@@ -23,6 +23,9 @@ import {
 import {Bubble} from '../../utils/bubble.js'
 
 declare global {
+  interface HTMLElementEventMap {
+    'assets-filesystem-change': CustomEvent<AssetsFilesystemChange>
+  }
   interface HTMLElementTagNameMap {
     'play-assets-local-archive': PlayAssetsLocalArchive
   }

diff --git a/src/elements/play-assets/play-assets-local-directory.ts b/src/elements/play-assets/play-assets-local-directory.ts
@@ -13,6 +13,9 @@ import {
 import {Bubble} from '../../utils/bubble.js'
 
 declare global {
+  interface HTMLElementEventMap {
+    'assets-filesystem-change': CustomEvent<AssetsFilesystemChange>
+  }
   interface HTMLElementTagNameMap {
     'play-assets-local-directory': PlayAssetsLocalDirectory
   }

diff --git a/src/elements/play-assets/play-assets-virtual-fs.ts b/src/elements/play-assets/play-assets-virtual-fs.ts
@@ -24,6 +24,9 @@ import '../play-icon/play-icon.js'
 import './file-upload-dropper.js'
 
 declare global {
+  interface HTMLElementEventMap {
+    'assets-virtual-file-change': CustomEvent<AssetsVirtualFileChange>
+  }
   interface HTMLElementTagNameMap {
     'play-assets-virtual-fs': PlayAssetsVirtualFilesystem
   }

diff --git a/src/elements/play-assets/play-assets.ts b/src/elements/play-assets/play-assets.ts
@@ -14,9 +14,7 @@ import {Bubble} from '../../utils/bubble.js'
 
 declare global {
   interface HTMLElementEventMap {
-    'assets-filesystem-change': CustomEvent<AssetsFilesystemChange>
     'assets-updated': CustomEvent<AssetsState>
-    'assets-virtual-file-change': CustomEvent<AssetsVirtualFileChange>
   }
   interface HTMLElementTagNameMap {
     'play-assets': PlayAssets

diff --git a/src/elements/play-pen/play-pen.ts b/src/elements/play-pen/play-pen.ts
@@ -435,7 +435,7 @@ export class PlayPen extends LitElement {
   }
 
   /** Throttled changes after updating sources. */
-  #setSrcSideEffects = throttle(async (save: boolean): Promise<void> => {
+  #setSrcSideEffects = throttle((save: boolean): void => {
     this.#version++
     this._bundle = link(
       compile(this.#env),