Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for camera select clearing on publisher source. #248

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix for camera select clearing on publisher source. #248

wants to merge 2 commits into from

Conversation

bustardcelly
Copy link
Contributor

  • clear out mediatracks on unpublish in camera select examples.

@bustardcelly
Copy link
Contributor Author

The issue was that the MediaTrack for the camera was not being properly cleared on some Mobile Device + Browsers.

Upon unpublish (which is invoked when switching cameras and starting a new broadcast), I added code to remove the previous MediaTrack and srcObject on the video element. Seems to have fixed the issue.

Tests affected:

  • Publish - Camera Source (WebRTC)
  • Publish - Stream Manager Proxy w/ Camera

Base automatically changed from develop to master May 17, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@beetlejesss beetlejesss

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bustardcelly @beetlejesss