#2138 Using requirements-external to specify git deps

- Had to do it for python 3.12 and 3.8 compat

Signed-off-by: David Davó <[email protected]>

recommenders/README.md

@@ -74,9 +74,11 @@ We are currently evaluating inclusion of the following dependencies:
 
 ## Other dependencies
 
-Some dependencies are not available via the recommenders PyPI package, but can be installed in the following ways: 
- - pymanopt: this dependency is required for the RLRMC and GeoIMC algorithms; a version of this code compatible with TensorFlow 2 can be
- installed with `pip install "git+https://github.com/pymanopt/pymanopt.git@1de3b6f47258820fdc072fceaeaa763b9fd263b0"`. 
+Some dependencies are not available via the recommenders PyPI package, but can be installed with the [requirements-external.txt](./requirements-external.txt) file:
+
+```
+pip install -r requirements-external.txt
+```
 
 ## NNI dependencies
 

requirements-external.txt

@@ -0,0 +1,5 @@
+# Jun 2024: Fixes py312
+pymanopt @git+https://github.com/pymanopt/pymanopt@1de3b6f47258820fdc072fceaeaa763b9fd263b0 ; python_version>='3.12'
+
+# 2024/02/29: pymanopt bumped to python 3.8
+pymanopt @git+https://github.com/pymanopt/pymanopt@e13cecaec3089c790cc93174840b2f557d179b3f ; python_version<'3.12'

setup.py

@@ -89,8 +89,8 @@
 ]
 
 # The following dependency can be installed as below, however PyPI does not allow direct URLs.
-# Temporary fix for pymanopt, only this commit works with TF2
-# "git+https://github.com/pymanopt/pymanopt.git@1de3b6f47258820fdc072fceaeaa763b9fd263b0",
+# Temporary fix for pymanopt, pypi version does not work with TF2
+# pip install -r requirements-external.txt
 
 setup(
     name="recommenders",