Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): tune phpunit config to be more verbose and strict #1154

Merged
merged 5 commits into from
Nov 19, 2024
Merged

chore(dev): tune phpunit config to be more verbose and strict #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa4be4b
phpunit: configure defaults, make it more strict
mfn Nov 19, 2024
374de16
phpunit: bump min version for --prefer-lowest which still support all…
mfn Nov 19, 2024
b1e677b
phpunit: don't fail on deprecations (yet)
mfn Nov 19, 2024
e0d60be
gha: use development php.ini file for tests
mfn Nov 19, 2024
5a18084
phpunit: don't fail on output (yet)
mfn Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
- uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
ini-file: development
coverage: none
extensions: pdo_sqlite

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"mockery/mockery": "^1.5",
"orchestra/testbench-core": "^8.0|^9.0",
"phpstan/phpstan": "^1",
"phpunit/phpunit": "^10.5",
"phpunit/phpunit": "^10.5.32",
"thecodingmachine/phpstan-safe-rule": "^1"
},
"autoload": {
Expand Down
13 changes: 13 additions & 0 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,20 @@
<phpunit
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd"
beStrictAboutChangesToGlobalState="true"
beStrictAboutOutputDuringTests="false"
beStrictAboutTestsThatDoNotTestAnything="true"
cacheDirectory=".phpunit.result.cache"
displayDetailsOnPhpunitDeprecations="true"
displayDetailsOnTestsThatTriggerDeprecations="true"
displayDetailsOnTestsThatTriggerErrors="true"
displayDetailsOnTestsThatTriggerNotices="true"
displayDetailsOnTestsThatTriggerWarnings="true"
failOnDeprecation="false"
failOnNotice="true"
failOnPhpunitDeprecation="false"
failOnRisky="true"
failOnWarning="true"
>
<testsuites>
<testsuite name="Unit">
Expand Down