Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): allow configuring number of threads for Dask workers #877

Merged
merged 1 commit into from
Feb 20, 2025
+10 −0
Merged

feat(helm): allow configuring number of threads for Dask workers #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions helm/reana/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ collisions.
| `dask.cluster_max_number_of_workers` | The maximum number of Dask workers that users can ask for | 20 |
| `dask.cluster_default_single_worker_memory` | The amount of memory used by default by a single Dask worker | "2Gi" |
| `dask.cluster_max_single_worker_memory` | The maximum amount of memory that users can ask for the single Dask worker | "8Gi" |
| `dask.cluster_default_single_worker_threads` | The number of threads used by default by a single Dask worker | 4 |
| `dask.cluster_max_single_worker_threads` | The maximum number of threads that users can ask for the single Dask worker | 8 |
| `db_env_config.REANA_DB_HOST` | Environment variable to connect to external databases | `<chart-release-name>-db` |
| `db_env_config.REANA_DB_NAME` | Environment variable to connect to external databases | reana |
| `db_env_config.REANA_DB_PORT` | Environment variable to connect to external databases | "5432" |
Expand Down
4 changes: 4 additions & 0 deletions helm/reana/templates/reana-server.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,10 @@ spec:
value: {{ .Values.dask.cluster_default_single_worker_memory | default "2Gi" }}
- name: REANA_DASK_CLUSTER_MAX_SINGLE_WORKER_MEMORY
value: {{ .Values.dask.cluster_max_single_worker_memory | default "8Gi" }}
- name: REANA_DASK_CLUSTER_DEFAULT_SINGLE_WORKER_THREADS
value: !!str {{ .Values.dask.cluster_default_single_worker_threads | default 4 }}
- name: REANA_DASK_CLUSTER_MAX_SINGLE_WORKER_THREADS
value: !!str {{ .Values.dask.cluster_max_single_worker_threads | default 8 }}
{{- end }}
- name: WORKSPACE_PATHS
value: {{ .Values.workspaces.paths | toJson | quote }}
Expand Down
2 changes: 2 additions & 0 deletions helm/reana/templates/reana-workflow-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ spec:
value: {{ .Values.dask.cluster_default_single_worker_memory | default "2Gi" }}
- name: REANA_DASK_CLUSTER_MAX_SINGLE_WORKER_MEMORY
value: {{ .Values.dask.cluster_max_single_worker_memory | default "8Gi" }}
- name: REANA_DASK_CLUSTER_DEFAULT_SINGLE_WORKER_THREADS
value: !!str {{ .Values.dask.cluster_default_single_worker_threads | default 4 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: ‏What about the following news headline:

feat(helm): allow configuring number of threads for Dask workers (#877)

{{- end }}
{{- if .Values.reana_hostname }}
- name: REANA_HOSTNAME
Expand Down
2 changes: 2 additions & 0 deletions helm/reana/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ dask:
cluster_max_number_of_workers: 20
cluster_default_single_worker_memory: "2Gi"
cluster_max_single_worker_memory: "8Gi"
cluster_default_single_worker_threads: 4
cluster_max_single_worker_threads: 8

pgbouncer:
enabled: false
Expand Down
Loading