Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): set localhost default value for REANA_HOSTNAME #717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(config): set localhost default value for REANA_HOSTNAME #717

wants to merge 1 commit into from

Conversation

Alputer
Copy link
Member

@Alputer Alputer commented Jan 31, 2025

This PR is part of harmonizing the treatment of REANA_HOSTNAME accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-workflow-controller#630

Closes reanahub/reana#865

@Alputer Alputer requested a review from tiborsimko January 31, 2025 11:47
@Alputer Alputer self-assigned this Jan 31, 2025
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 31, 2025
@Alputer
fix(config): set localhost default value for REANA_HOSTNAME (reanahub…
d4df3a3 
…#630)

This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-server#717

Closes reanahub/reana#865
This was referenced Jan 31, 2025
Open
Open
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.06%. Comparing base (e54b414) to head (a24c810).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
+ Coverage   60.03%   60.06%   +0.02%     
==========================================
  Files          32       32              
  Lines        3588     3588              
==========================================
+ Hits         2154     2155       +1     
+ Misses       1434     1433       -1
Files with missing lines Coverage Δ
reana_server/config.py 84.97% <100.00%> (+0.51%) ⬆️
reana_server/utils.py 59.15% <ø> (ø)

Alputer added a commit to Alputer/reana that referenced this pull request Jan 31, 2025
@Alputer
fix(helm): harmonize default value for REANA_HOSTNAME (reanahub#867)
54ec108 
This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana-server#717
reanahub/reana-workflow-controller#630

Closes reanahub#865
Alputer added a commit to Alputer/reana that referenced this pull request Jan 31, 2025
@Alputer
fix(helm): harmonize default value for REANA_HOSTNAME (reanahub#867)
db4c4ae 
This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana-server#717
reanahub/reana-workflow-controller#630

Closes reanahub#865
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 31, 2025
@Alputer
fix(config): set localhost default value for REANA_HOSTNAME (reanahub…
d31a3dd 
…#630)

This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-server#717

Closes reanahub/reana#865
Alputer added a commit to Alputer/reana-server that referenced this pull request Jan 31, 2025
@Alputer
fix(config): set localhost default value for REANA_HOSTNAME (reanahub…
d6e06aa 
…#717)

This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-workflow-controller#630

Closes reanahub/reana#865
@Alputer Alputer force-pushed the fix-reana-hostname branch from d4d40a8 to d6e06aa Compare January 31, 2025 12:55
@Alputer
fix(config): set localhost default value for REANA_HOSTNAME (reanahub…
a24c810 
…#717)

This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-workflow-controller#630

Closes reanahub/reana#865
@Alputer Alputer force-pushed the fix-reana-hostname branch from d6e06aa to a24c810 Compare January 31, 2025 13:42
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 31, 2025
@Alputer
fix(config): set localhost default value for REANA_HOSTNAME (reanahub…
fd40874 
…#630)

This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-server#717

Closes reanahub/reana#865
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 31, 2025
@Alputer
fix(config): set localhost default value for REANA_HOSTNAME (reanahub…
8a8da3a 
…#630)

This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-server#717

Closes reanahub/reana#865
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 31, 2025
@Alputer
fix(config): set localhost default value for REANA_HOSTNAME (reanahub…
f26b0cc 
…#630)

This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-server#717

Closes reanahub/reana#865
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 31, 2025
@Alputer
fix(dask): use correct REANA host port for Dask service URLs (reanahu…
6819003 
…b#630)

This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-server#717

Closes reanahub/reana#865
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 31, 2025
@Alputer
fix(dask): use correct REANA host port for Dask service URLs (reanahu…
bcda677 
…b#630)

This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-server#717

Closes reanahub/reana#865
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 31, 2025
@Alputer
fix(dask): use correct REANA host port for Dask service URLs (reanahu…
bf8d7e1 
…b#630)

This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-server#717

Closes reanahub/reana#865
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 31, 2025
@Alputer
fix(dask): use correct REANA host port for Dask service URLs (reanahu…
64dfed1 
…b#630)

This PR is part of harmonizing the treatment of REANA_HOSTNAME
accross all REANA components. You can refer to other PRs below.

reanahub/reana#867
reanahub/reana-server#717

Closes reanahub/reana#865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborsimko tiborsimko Awaiting requested review from tiborsimko

At least 1 approving review is required to merge this pull request.

Assignees

@Alputer Alputer

Labels
None yet
Projects
0.95.0
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm: harmonise the treatment of reana_hostname
1 participant
@Alputer