RT-15535: Extra description for additionalfields.php #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbrag
approved these changes
Nov 28, 2024
| @@ -20,63 +20,62 @@ public function __invoke(Request $request) | |||
| { | |||
| $results = new ResultsList(); | |||
|
|
|||
| if (App::registrarConfig()->customerHandle() !== '') { | |||
There was a problem hiding this comment.
This was added so we didn't get an error trying to sync while there was no customerdata set (yet). I don;t think it needs to be removed?
There was a problem hiding this comment.
it's not removed? Just placed as a guard clause to reduce indenting
| @@ -105,4 +106,15 @@ function ($field) { | |||
| } | |||
| } | |||
|
|
|||
| /* Add custom fields here, example | |||
There was a problem hiding this comment.
Is this an example for an override(translation), or for an extra field, which doesn't come from Realtime Register?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.