Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v7.4.0 #331

Merged
merged 21 commits into from
Jan 15, 2025
Merged

Release/v7.4.0 #331

merged 21 commits into from
Jan 15, 2025

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Jan 10, 2025

TICKETID

Description

Updated

  • Avatar caching location is now changed when running in the Unity Editor it will now be stored in the Application.persistentDataPath directory as it already did for builds. However when loading avatars from the Avatar Loader Editor window it will still store them in the Assets/Ready Player Me/Avatars folder.
  • AvatarManager and AvatarHandler classes updated so that in the Avatar Creator Elements sample it will re-equip hair when headwear is removed. #330
  • AvatarConfigProcessor updated so that by default if morph targets are not set, it will set it to None to improve file size. #326
  • AvatarConfigProcessor now sets textureType with every request to prevent webp texture the cause downloads to fail. #326

How to Test

Import the sdk via this url

https://github.com/readyplayerme/rpm-unity-sdk-core.git#release/v7.4.0

Headwear and hair fix

  1. Open and run the Avatar Creator Elements scene
  2. Equip a hair style (make note of which style you picked
  3. equip a head wear and make sure it is equipped and hair is removed
  4. now unequip the headwear
  5. check that the same hair is re-equipped

Avatar caching location update

  • check that all the samples work with caching enabled and disabled (no reason why they shouldnt). Make sure that no avatars get stored in assets folder (you can go to RPM Settings Window and click "show in explorer" to open the folder that they should show up in (it is same as where they are stored in builds)
  • Check that the Avatar Loader Window still works & it stores avatars in Assets/Ready Player Me/ Avatars folder

Avatar config processor updates

  • not really a way to test other than our Unit tests in the editor, just make sure general avatar loading works in samples

If you want to test builds you can use the actions here to trigger them (they take some time though

https://github.com/readyplayerme/Unity-SDK/actions

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

HarrisonHough and others added 16 commits October 23, 2024 09:58
## Description

This should fix issue #323, where for some AudioClip lengths the
GetAmplitude method tried to read data from the clip even if the
remaining samples were 0.

## How to Test

- add VoiceHandler component on an avatar
- set build target to webGL and run the built application
- let the AudioSource referenced by the VoiceHandler reproduce
AudioClips with various lengths

## Checklist

- [ ] Tests written or updated for the changes.
- [ ] Documentation is updated.
- [ ] Changelog is updated.
## [SRV-1555](https://ready-player-me.atlassian.net/browse/SRV-1555)

## Description

- Fixes #325.
- These changes ensure that equipped colors are now taken into account
when loading an avatar, instead of defaulting to the first color.

## How to Test

- Open the AvatarCreatorWizard scene.
- Create a new avatar using the template.
- In the editor, navigate to the skin, eyebrow, hair, or beard category.
- Verify that the displayed color matches what the avatar is currently
wearing.


https://github.com/user-attachments/assets/0a8c7992-ed94-4ece-8b66-9cf7bbbf2962

[SRV-1555]:
https://ready-player-me.atlassian.net/browse/SRV-1555?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Harrison Hough <[email protected]>
@HarrisonHough HarrisonHough requested a review from a team as a code owner January 10, 2025 09:00
@HarrisonHough HarrisonHough merged commit 0f11fca into main Jan 15, 2025
1 check failed
@HarrisonHough HarrisonHough deleted the release/v7.4.0 branch January 15, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants