Fix wrongly ordered assertThat#withFailMessage not showing #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in Part11BlockingToReactiveTest.slowPublisherFastSubscriber method: withFailMessage is ignored and no fail message will be show.
assertThat(repository.getCallCount()).isEqualTo(0).withFailMessage("The call to findAll must be deferred until the flux is subscribed");
To test that modify Part11BlockingToReactive.blockingRepositoryToFlux mothod as following:
return Flux.fromIterable(repository.findAll());
the test will failed but fail message is not displayed.
after small change, it is fixed:
assertThat(repository.getCallCount()) .withFailMessage("The call to findAll must be deferred until the flux is subscribed") .isEqualTo(0);
now the fail message is displayed if the assert is false.
hope my request is useful.
Thanks.