Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #75 Add Flux.collect exercise in solution branch #74

Merged
merged 3 commits into from
Sep 21, 2020

Conversation

paweusz
Copy link
Contributor

@paweusz paweusz commented Sep 10, 2020

As currently there's no exercise for Flux.collect...() methods I thought that at least one case could be helpful.

@simonbasle
Copy link
Contributor

Hi @paweusz and thanks for offering this contribution.
Mentioning collectList could indeed make sense.

There are 3 parts to adding an operator to the hands on, which cannot be covered by a single PR: master has the empty exercise to be filled by the user, techio_course has the same + a more fleshed out description of the operator and what's expected of the user in a markdown file (displayed along the code on tech.io) and the third branch solution has the filled solution to the exercise.

I think ideally an issue would be a better format, as you can A) discuss the solution and techio_course parts and B) optionally submit 3 PRs that each refer the same issue. wdyt?

@paweusz
Copy link
Contributor Author

paweusz commented Sep 16, 2020

Thx, will do.

@paweusz paweusz changed the title Add a case for flux.collectList() Fixes #75 (Flux.collect) in solution branch Sep 17, 2020
@simonbasle simonbasle changed the title Fixes #75 (Flux.collect) in solution branch fix #75 Add Flux.collect exercise in solution branch Sep 21, 2020
@simonbasle simonbasle merged commit dc54d7e into reactor:solution Sep 21, 2020
simonbasle added a commit that referenced this pull request Feb 16, 2021
simonbasle added a commit that referenced this pull request May 10, 2021
simonbasle added a commit that referenced this pull request Oct 19, 2021
simonbasle added a commit that referenced this pull request Feb 24, 2022
simonbasle added a commit that referenced this pull request Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants