Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to core 3.3, RxJava 3, JUnit 5 and improve tests #71

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Bump to core 3.3, RxJava 3, JUnit 5 and improve tests #71

merged 1 commit into from
Apr 22, 2020

Conversation

aneveu
Copy link
Contributor

@aneveu aneveu commented Mar 30, 2020

  • Update to Dysprosium-SR6
  • Update to RxJava 3.0.1
  • Update to JUnit 5.6.1
  • Update to AssertJ 3.15.0
  • Assert to LogBack 1.2.3
  • Fix missing import into Part09
  • Improve instructions into Part06#Test2

@aneveu aneveu requested a review from simonbasle March 30, 2020 14:58
@aneveu aneveu force-pushed the upgradeLibrairiesVersions branch from 40fb5b0 to caa0cc7 Compare March 31, 2020 15:42
simonbasle
simonbasle suggested changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick on the assertion change

src/test/java/io/pivotal/literx/Part11BlockingToReactiveTest.java Outdated Show resolved Hide resolved
@aneveu aneveu force-pushed the upgradeLibrairiesVersions branch 3 times, most recently from a654034 to 03e16c0 Compare April 6, 2020 17:06
@aneveu aneveu force-pushed the upgradeLibrairiesVersions branch from 03e16c0 to 4891036 Compare April 17, 2020 08:45
@aneveu aneveu requested a review from a team April 20, 2020 16:09
@aneveu aneveu changed the title Various fix and updates: Bump to core 3.3, RxJava 3, JUnit 5 and improve tests Apr 22, 2020
Bump to core 3.3, RxJava 3, JUnit 5 and improve tests
11eb476 
- Update to Dysprosium-SR6
- Update to RxJava 3.0.1
- Update to JUnit 5.6.1
- Update to AssertJ 3.15.0
- Update to LogBack 1.2.3
- Improve instructions into Part06#Test2
- Check the output to complete tests in Part06
@aneveu aneveu force-pushed the upgradeLibrairiesVersions branch from 4891036 to 11eb476 Compare April 22, 2020 12:52
@aneveu aneveu merged commit 356d928 into master Apr 22, 2020
@aneveu aneveu deleted the upgradeLibrairiesVersions branch April 22, 2020 12:53
@pascalleclercq pascalleclercq mentioned this pull request Nov 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbasle simonbasle simonbasle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aneveu @simonbasle