Part06Request. Task specification clarified. Typos. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,14 +17,14 @@ | |||
|
|
|||
| //======================================================================================== | |||
|
|
|||
| // TODO Create a StepVerifier that initially requests all values and expect 4 values to be received | |||
| // TODO Create a StepVerifier that expects 4 values to be received and requests all remaining values | |||
There was a problem hiding this comment.
this is not a good change. the initially requests all values part is important, as a duality to initially requests 1 value in the next test.
| @@ -38,7 +38,7 @@ StepVerifier requestOneExpectSkylerThenRequestOneExpectJesse(Flux<User> flux) { | |||
|
|
|||
| //======================================================================================== | |||
|
|
|||
| // TODO Return a Flux with all users stored in the repository that prints "Starring:" on subscribe, "firstname lastname" for all values and "The end!" on complete | |||
| // TODO Return a Flux with all users stored in the repository that prints "Starting:" on subscribe, "firstname lastname" for all values and "The end!" on complete | |||
There was a problem hiding this comment.
This is not a typo: Starring, as "a movie starring user1, user2, user3, ..." (see the solution branch). That said, the associated test doesn't check the console output, so it is not terribly meaningful.
| StepVerifier requestAllExpectFour(Flux<User> flux) { | ||
| return null; | ||
| } | ||
|
|
||
| //======================================================================================== | ||
|
|
||
| // TODO Create a StepVerifier that initially requests 1 value and expects User.SKYLER then requests another value and expects User.JESSE. | ||
| // TODO Create a StepVerifier that initially requests 1 value and expects User.SKYLER then requests another value and expects User.JESSE then stops request. |
There was a problem hiding this comment.
could be made even more explicit by stating "then stops verifying by cancelling the source"
simonbasle
suggested changes
Jan 6, 2020
|
closing this has review comments have never been addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PR will accepted it also may be applied to 'solution' branch