[Part.06 fluxWithLog Test Bug Fix] The test will only pass when Person is changed to User. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonbasle @chemicL Hi there! Could you please review and merge my pr if it makes sense and there are no objections. I have tagged you as you are the last person active on this repo and have the necessary permissions. |
|
@DaehyeokYou your PR contains a lot of unrelated and undesired changes, please only submit a changeset that touches the intended area. |
|
I merged the other PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PR #98(updated the toString output to User{}) was merged (updated the toString output to User{}), the expected value in the test assertions still contains 'Person'.
This needs to be updated to 'User' for correct test validation.
I kindly request the merge of my PR to address this issue.