-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: overflowY = 'auto' when set scroll.y #973
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
- Coverage 99.52% 99.49% -0.03%
==========================================
Files 40 36 -4
Lines 3563 989 -2574
Branches 476 320 -156
==========================================
- Hits 3546 984 -2562
+ Misses 17 5 -12
... and 40 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6f4e347
to
a146e9b
Compare
@@ -315,7 +315,7 @@ function Table<RecordType extends DefaultRecordType>(tableProps: TableProps<Reco | |||
|
|||
if (fixHeader) { | |||
scrollYStyle = { | |||
overflowY: 'scroll', | |||
overflowY: 'auto', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
table { you can add or Modify box-sizing to border-box in the parent table good luck.. |
Currently, if we set the value of
scroll.y
but the height of all items in the table does not exceedscroll.y
, There is still an empty scroll barI think it would be better if we set the
overflowY
isauto
, the result after the change.