Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent attributes to full export #1000

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Add parent attributes to full export #1000

merged 2 commits into from
Jun 20, 2024

Conversation

jochenklar
Copy link
Member

This PR adds all parent attributes to the full export feature.

@jochenklar jochenklar requested a review from MyPyDavid May 17, 2024 17:44
@jochenklar jochenklar self-assigned this May 17, 2024
@MyPyDavid
Copy link
Member

PR number 1000 🎉

@MyPyDavid MyPyDavid added this to the RDMO 2.2.0 milestone May 22, 2024
@MyPyDavid
Copy link
Member

do you not want to have any tests for this?
For example in here:

def test_detail_export(db, client, username, password, export_format):
?

@jochenklar
Copy link
Member Author

I mean, there is a test, right? We could test that everything is there though.

@MyPyDavid
Copy link
Member

yes a general test is there, I mean testing for the specific content of the exported xml (which attributes should be in there..)

@jochenklar
Copy link
Member Author

I added some tests.

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jochenklar jochenklar merged commit a0b05ed into dev-2.2.0 Jun 20, 2024
17 checks passed
@jochenklar jochenklar deleted the fix_full_export branch June 20, 2024 07:56
jochenklar added a commit that referenced this pull request Jun 20, 2024
Add parent attributes to full export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants