Skip to content

Commit

Permalink
style: make ruff and ignore long lines
Browse files Browse the repository at this point in the history
Signed-off-by: David Wallace <[email protected]>
  • Loading branch information
MyPyDavid committed Apr 10, 2024
1 parent dfc5fbb commit c3ffc99
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
6 changes: 2 additions & 4 deletions rdmo/core/imports.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,7 @@ def set_foreign_field(instance, field_name, element, uploaded_uris=None, origina
return

if 'uri' not in foreign_element:
message = 'Foreign model can not be assigned on {instance_model}.{field_name} {instance_uri} due to missing uri.'.format(
# noqa: E501
message = 'Foreign model can not be assigned on {instance_model}.{field_name} {instance_uri} due to missing uri.'.format( # noqa: E501
instance_model=instance._meta.object_name,
instance_uri=element.get('uri'),
field_name=field_name
Expand Down Expand Up @@ -226,8 +225,7 @@ def set_foreign_field(instance, field_name, element, uploaded_uris=None, origina
_foreign_uri,
original=original)
except ValueError:
message = '{foreign_model} {foreign_uri} can not be assigned on {instance_model}.{field_name} {instance_uri} .'.format(
# noqa: E501
message = '{foreign_model} {foreign_uri} can not be assigned on {instance_model}.{field_name} {instance_uri} .'.format( # noqa: E501
foreign_model=foreign_model._meta.object_name,
foreign_uri=foreign_uri,
instance_model=instance._meta.object_name,
Expand Down
2 changes: 1 addition & 1 deletion rdmo/management/tests/helpers_import_elements.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from functools import partial
from typing import Dict, List, Optional, Tuple, Union

from rdmo.core.imports import track_changes_on_element, ELEMENT_DIFF_FIELD_NAME, NEW_DATA_FIELD, CURRENT_DATA_FIELD
from rdmo.core.imports import CURRENT_DATA_FIELD, ELEMENT_DIFF_FIELD_NAME, NEW_DATA_FIELD, track_changes_on_element
from rdmo.management.imports import _initialize_import_element_dict

UPDATE_FIELD_FUNCS = {
Expand Down
11 changes: 6 additions & 5 deletions rdmo/management/tests/test_import_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

import pytest

from rdmo.core.imports import ELEMENT_DIFF_FIELD_NAME, NEW_DATA_FIELD, CURRENT_DATA_FIELD
from rdmo.core.imports import CURRENT_DATA_FIELD, ELEMENT_DIFF_FIELD_NAME, NEW_DATA_FIELD
from rdmo.management.imports import import_elements
from rdmo.options.models import Option, OptionSet

from .helpers_import_elements import (
_test_helper_change_fields_elements,
_test_helper_filter_updated_and_changed,
get_changed_elements
get_changed_elements,
)
from .helpers_models import delete_all_objects
from .helpers_xml import read_xml_and_parse_to_elements
Expand Down Expand Up @@ -98,11 +98,12 @@ def test_update_optionsets_from_changed_xml(db, settings):
assert len([i for i in changed_elements.values() if i]) == 5

# change the order of the options, as in the xml
optionset_element = [i for i in imported_elements_1 if i['uri'] == test_optionset['original']['uri']][0]
test_optionset_changed_options = test_optionset['original']['options'][::-1] # the test changes are simply the reversed order of the options
optionset_element = next([i for i in imported_elements_1 if i['uri'] == test_optionset['original']['uri']])
# the test changes are simply the reversed order of the options
test_optionset_changed_options = test_optionset['original']['options'][::-1]
assert optionset_element
assert "options" in optionset_element[ELEMENT_DIFF_FIELD_NAME]
assert optionset_element[ELEMENT_DIFF_FIELD_NAME]['options'][CURRENT_DATA_FIELD] == test_optionset['original']['options']
assert optionset_element[ELEMENT_DIFF_FIELD_NAME]['options'][CURRENT_DATA_FIELD] == test_optionset['original']['options'] # noqa: E501
assert optionset_element[ELEMENT_DIFF_FIELD_NAME]['options'][NEW_DATA_FIELD] == test_optionset_changed_options

# now save the elements_1
Expand Down

0 comments on commit c3ffc99

Please sign in to comment.