Fix migration, again

rdmorganiser · Feb 13, 2024 · 289e777 · 289e777
1 parent 42540ef
commit 289e777
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/rdmo/options/migrations/0032_alter_option_additional_input.py b/rdmo/options/migrations/0032_alter_option_additional_input.py
@@ -7,7 +7,7 @@ def run_data_migration(apps, schema_editor):
     Option = apps.get_model('options', 'Option')
 
     for option in Option.objects.all():
-        option.additional_input = 'text' if option.additional_input == 'true' else ''
+        option.additional_input_string = 'text' if option.additional_input is True else ''
         option.save()
 
 
@@ -18,10 +18,19 @@ class Migration(migrations.Migration):
     ]
 
     operations = [
-        migrations.AlterField(
+        migrations.AddField(
             model_name='option',
-            name='additional_input',
-            field=models.CharField(blank=True, choices=[('', '---------'), ('text', 'Text'), ('textarea', 'Textarea')], default=False, help_text='Designates whether an additional input is possible for this option.', max_length=256, verbose_name='Additional input'),
+            name='additional_input_string',
+            field=models.CharField(blank=True, choices=[('', '---------'), ('text', 'Text'), ('textarea', 'Textarea')], default='', help_text='Designates whether an additional input is possible for this option.', max_length=256, verbose_name='Additional input'),
         ),
         migrations.RunPython(run_data_migration),
+        migrations.RemoveField(
+            model_name='option',
+            name='additional_input',
+        ),
+        migrations.RenameField(
+            model_name='option',
+            old_name='additional_input_string',
+            new_name='additional_input',
+        ),
     ]
diff --git a/rdmo/options/models.py b/rdmo/options/models.py
@@ -262,7 +262,7 @@ class Option(models.Model, TranslationMixin):
         help_text=_('The view text for this option (in the quinary language).')
     )
     additional_input = models.CharField(
-        max_length=256, blank=True, default=False, choices=ADDITIONAL_INPUT_CHOICES,
+        max_length=256, blank=True, default=ADDITIONAL_INPUT_NONE, choices=ADDITIONAL_INPUT_CHOICES,
         verbose_name=_('Additional input'),
         help_text=_('Designates whether an additional input is possible for this option.')
     )