Merge pull request #1246 from rdmorganiser/1244-bug-in-saving-short-t…

…itle-when-value-is-too-long-for-page-and-section

Add max length validation to translated fields.
Related issue: #1244

rdmo/core/serializers.py

@@ -2,6 +2,7 @@
 
 from django.contrib.auth.models import Group
 from django.contrib.sites.models import Site
+from django.core.validators import MaxLengthValidator
 from django.db.models import Max
 
 from rest_framework import serializers
@@ -58,11 +59,17 @@ def __init__(self, *args, **kwargs):
                 field_name = f'{field}_{lang_field}'
                 model_field = meta.model._meta.get_field(field_name)
 
+                validators = []
+                if hasattr(model_field, 'max_length') and model_field.max_length is not None:
+                    validators.append(MaxLengthValidator(model_field.max_length))
+
                 self.fields[f'{field}_{lang_code}'] = serializers.CharField(
                     source=field_name,
                     required=not model_field.blank,
                     allow_null=model_field.null,
-                    allow_blank=model_field.blank)
+                    allow_blank=model_field.blank,
+                    validators=validators
+                )
 
 
 class ThroughModelSerializerMixin:

rdmo/questions/tests/test_viewset_page.py

@@ -347,3 +347,19 @@ def test_detail_export_full(db, client):
     assert 'http://example.com/terms/domain/conditions' in uris
     assert 'http://example.com/terms/options/one_two_three' in uris
     assert 'http://example.com/terms/options/one_two_three/one' in uris
+
+def test_update_page_field_validation_short_title(db, client):
+    username = password = 'editor'
+    client.login(username=username, password=password)
+    instance = Page.objects.first()
+    very_long_title = 'short_title, ' * 10
+
+    url = reverse(urlnames['detail'], args=[instance.pk])
+    data = {
+        'uri_prefix': instance.uri_prefix,
+        'uri_path': instance.uri_path,
+        'short_title_en': very_long_title,
+    }
+    response = client.put(url, data, content_type='application/json')
+    assert response.status_code == 400
+    assert response.json() == {'short_title_en': ['Ensure this value has at most 32 characters (it has 129).']}

rdmo/questions/tests/test_viewset_section.py

@@ -292,3 +292,20 @@ def test_detail_export_full(db, client):
     assert 'http://example.com/terms/domain/conditions' in uris
     assert 'http://example.com/terms/options/one_two_three' in uris
     assert 'http://example.com/terms/options/one_two_three/one' in uris
+
+
+def test_update_section_field_validation_short_title(db: object, client: object) -> None:
+    username = password = 'editor'
+    client.login(username=username, password=password)
+    instance = Section.objects.first()
+    very_long_title = 'short_title, ' * 10
+
+    url = reverse(urlnames['detail'], args=[instance.pk])
+    data = {
+        'uri_prefix': instance.uri_prefix,
+        'uri_path': instance.uri_path,
+        'short_title_de': very_long_title,
+    }
+    response = client.put(url, data, content_type='application/json')
+    assert response.status_code == 400
+    assert response.json() == {'short_title_de': ['Ensure this value has at most 32 characters (it has 129).']}