Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix topic for subscription retry #310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix topic for subscription retry #310

wants to merge 1 commit into from

Conversation

vnktram
Copy link
Contributor

@vnktram vnktram commented Feb 22, 2022

No description provided.

@vnktram vnktram requested a review from rutul25 February 22, 2022 09:03
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #310 (3af09f4) into master (bcfa7cf) will decrease coverage by 0.25%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   43.91%   43.66%   -0.26%     
==========================================
  Files         121      121              
  Lines        6216     6222       +6     
==========================================
- Hits         2730     2717      -13     
- Misses       3282     3303      +21     
+ Partials      204      202       -2     
Flag Coverage Δ
integration 29.63% <ø> (ø)
unittests 41.59% <22.22%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/subscription/core.go 13.04% <0.00%> (-0.39%) ⬇️
internal/subscription/model.go 90.16% <100.00%> (ø)
internal/stream/stream.go 27.35% <0.00%> (-5.67%) ⬇️
internal/subscriber/model.go 32.23% <0.00%> (-1.66%) ⬇️
internal/scheduler/loadbalancealgoimpl.go 81.25% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcfa7cf...3af09f4. Read the comment docs.

@vnktram vnktram added wip Work in progress do-not-merge labels Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants