Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore java/**/bin #5222

Closed
wants to merge 1 commit into from
Closed

ignore java/**/bin #5222

wants to merge 1 commit into from

Conversation

ConeyLiu
Copy link
Contributor

What do these changes do?

ignore java/**/bin

Related issue number

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@raulchen
Copy link
Contributor

which particular directories do you want to ignore? I don't see any bin directories under java

@ConeyLiu
Copy link
Contributor Author

It will auto-generate when you build self wheels as the doc mentioned: docker run --rm -w /ray -v pwd:/ray -ti rayproject/arrow_linux_x86_64_base:latest /ray/python/build-wheel-manylinux1.sh

@raulchen
Copy link
Contributor

Interesting, building python wheels shouldn't generate files in Java dir. Can you list the dirty files?

@ConeyLiu
Copy link
Contributor Author

I will try to regenerate it. It happens when I build wheels and cancel it in the middle.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15472/
Test PASSed.

@ConeyLiu
Copy link
Contributor Author

Hi @raulchen, this should be caused by vscode java plugin bug. The bug is here: redhat-developer/vscode-java#634. Not sure this patch should be merged.

@raulchen
Copy link
Contributor

Hi @raulchen, this should be caused by vscode java plugin bug. The bug is here: redhat-developer/vscode-java#634. Not sure this patch should be merged.

I see, thanks. Since this bug is not specific to ray, I think you can add the ignore item to your local config file (~/.config/git/ignore) until the bug is fixed.

@ConeyLiu
Copy link
Contributor Author

OK, thanks a lot. Close this.

@ConeyLiu ConeyLiu closed this Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants