-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]chore: add compileDependencies default value #47
base: master
Are you sure you want to change the base?
Conversation
要不要默认升级到 webpack 5? |
还没完全验证过,下周看下吧 |
scaffolds/app-ts/src/app.json
Outdated
@@ -7,5 +7,8 @@ | |||
], | |||
"window": { | |||
"title": "Rax App" | |||
}, | |||
"builtInLibrary": { | |||
"lib-mtop": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
外部用户会不会困惑,def 的逻辑是放在 generate 里处理的
compileDependencies 增量用户为 [] 这个是什么背景? |
对于 Rax 用户而言,全量编译 node_modules 解决的是两个问题:1. 移除其它端的冗余代码,后续会推使用 |
@SoloJiang 有个背景是现在很多包不规范,预先没编译,这样切换还是有之前的风险在,这个点怎么考虑?开发时有这样的情况给开发者提示下然后让他加到 compileDependencies 里? |
先 hold 吧,我测试下这个插件能不能在构建时提示:https://github.com/bitjourney/check-es-version-webpack-plugin |
@SoloJiang 这块还是要把策略想好,比如:
短期要规避问题,长期要推进这些包的标准化。 |
compileDependencies
增量用户为[]