Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): rename import from pwc #66

Merged
merged 2 commits into from
May 6, 2022
Merged

Conversation

ChrisCindy
Copy link
Contributor

To avoid name conflict, variables imported from pwc are renamed with "__" prefix:

import { reactive as __reactive, customElement as __customElement } from 'pwc';

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022

Codecov Report

Merging #66 (eee3150) into main (9e2bc7d) will increase coverage by 0.33%.
The diff coverage is 100.00%.

❗ Current head eee3150 differs from pull request most recent head 5dd3adf. Consider uploading reports for the commit 5dd3adf to get more accurate results

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   85.23%   85.57%   +0.33%     
==========================================
  Files          41       41              
  Lines         806      804       -2     
  Branches      188      182       -6     
==========================================
+ Hits          687      688       +1     
+ Misses        119      116       -3     
Impacted Files Coverage Δ
...ages/pwc-compiler/src/transform/autoAddAccessor.ts 100.00% <100.00%> (ø)
...ler/src/transform/autoAddCustomElementDecorator.ts 100.00% <100.00%> (ø)
...compiler/src/transform/autoAddReactiveDecorator.ts 98.21% <100.00%> (+0.03%) ⬆️
.../pwc-compiler/src/transform/autoInjectImportPWC.ts 100.00% <100.00%> (+10.00%) ⬆️
packages/pwc-compiler/src/transform/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e2bc7d...5dd3adf. Read the comment docs.

SoloJiang
SoloJiang previously approved these changes Apr 26, 2022
@ChrisCindy ChrisCindy linked an issue Apr 26, 2022 that may be closed by this pull request
cryzzchen
cryzzchen previously approved these changes Apr 27, 2022
@ChrisCindy ChrisCindy dismissed stale reviews from cryzzchen and SoloJiang via 5dd3adf May 6, 2022 03:03
@ChrisCindy ChrisCindy merged commit e5b302d into main May 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat/rename-import branch May 6, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] 编译器自动引入装饰器重命名
4 participants