fix: get template method trigger times #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisCindy
reviewed
Apr 2, 2022
| @@ -10,7 +10,7 @@ export default (Definition) => { | |||
| return class extends Definition implements PWCElement { | |||
| #uid: number = generateUid(); | |||
| // Component initial state | |||
| #initialized = false; | |||
| __initialized = false; | |||
ChrisCindy
approved these changes
Apr 2, 2022
cryzzchen
approved these changes
Apr 2, 2022
SoloJiang
added a commit
that referenced
this pull request
Apr 2, 2022
* feat(compiler+runtime): integrate compile function into pwc runtime * feat: use pkg-cli to compile packages * chore(example): update rollup config * build: update pnpm lock file * chore: remove .js extension * feat(plyground): add playground * feat(compiler): handle situation without template block * fix: lint error * build: update lock file * chore(example): update runtime * feat(playground): support update code in editor * fix(playground): lint error * fix(compiler): miss add accessor * test: add pwc-compiler test cases (#34) * refactor(compiler): update data structure of get template * feat(compiler): finish compileTemplateInRuntime method * chore(example): update runtime example * fix: lint error * chore(playground): remove playground code * refactor: attribute format * chore: remove debugger * chore: change type to interface * chore: lint * chore: add capture type * fix(compiler): handle reactive import * fix(compiler): test case of import specifiers in pwc * chore(compiler): update for comment * fix: get template method trigger times (#36) * fix: get template method trigger times * fix: get template method trigger times * chore: remove useless code * chore: typo Co-authored-by: Rongyan Chen <[email protected]> Co-authored-by: fushen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.