Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/env fragment shaking #304

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feat/env fragment shaking #304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06bdd95
feat(script-loader): support platform-loader
shiftj18 Sep 9, 2022
1c72199
feat(script-loader): support platform-loader of npm
shiftj18 Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions packages/jsx2mp-loader/src/script-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,11 @@ module.exports = function scriptLoader(content) {
const outputFile = (rawContent, isFromNpm = true) => {
let distSourcePath;
if (isFromNpm) {
const relativeNpmPath = relative(currentNodeModulePath, this.resourcePath);
const splitedNpmPath = relativeNpmPath.split(sep);
if (/^_?@/.test(relativeNpmPath)) splitedNpmPath.shift(); // Extra shift for scoped npm.
splitedNpmPath.shift(); // Skip npm module package, for cnpm/tnpm will rewrite this.
// 以下四行开销测下来用不到，故注释
// const relativeNpmPath = relative(currentNodeModulePath, this.resourcePath);
// const splitedNpmPath = relativeNpmPath.split(sep);
// if (/^_?@/.test(relativeNpmPath)) splitedNpmPath.shift(); // Extra shift for scoped npm.
// splitedNpmPath.shift(); // Skip npm module package, for cnpm/tnpm will rewrite this.
distSourcePath = normalizeNpmFileName(join(outputPath, 'npm', relative(rootNodeModulePath, this.resourcePath)));
} else {
const relativeFilePath = relative(
Expand Down Expand Up @@ -235,7 +236,8 @@ module.exports = function scriptLoader(content) {
content
].join('\n');
} else {
outputFile(rawContent);
// outputFile(rawContent);
outputFile(content);
}
} else if (isFromConstantDir(this.resourcePath) && isThirdMiniappComponent) {
const dependencies = [];
Expand All @@ -258,7 +260,10 @@ module.exports = function scriptLoader(content) {
content
].join('\n');
} else if (!isAppJSon) {
outputFile(rawContent, false);
// outputFile(rawContent, false);
// content 是过了 rax-platform-loader 的（会包含 env 变量转换为布尔常量化），而 rawContent 是没有这个转换的;
// 后续的 babel-plugin-minify-dead-code-elimination-while-loop-fixed 依赖布尔常量来 tree-shaking.
outputFile(content, false);
}

return isJSON ? '{}' : transformCode(
Expand Down