Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

margin and scroll #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

margin and scroll #15

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
906af77
margin and scroll
adin234 Jul 3, 2015
59e7dae
fix css
adin234 Feb 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#messages { list-style-type: none; margin: 0; padding: 0; }
#messages li { padding: 5px 10px; }
#messages li:nth-child(odd) { background: #eee; }
#msg { margin-bottom: 40px }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't work for me in Firefox nor Safari - the lowest two lines are still covered by the chat block. In fact, there is no "msg" item in the html code, so this makes little sense. It seems there's something else missing.

</style>
</head>
<body>
Expand All @@ -29,6 +30,7 @@
});
socket.on('chat message', function(msg){
$('#messages').append($('<li>').text(msg));
window.scrollTo(0,document.body.scrollHeight);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and works for me

});
</script>
</body>
Expand Down